Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks quotes inside of quotes #320

Open
KTibow opened this issue Nov 12, 2022 · 5 comments
Open

Breaks quotes inside of quotes #320

KTibow opened this issue Nov 12, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@KTibow
Copy link
Contributor

KTibow commented Nov 12, 2022

If you have something like <Component prop='Something in "quotes".' /> this plugin turns it into "Something in "quotes"." which is invalid Svelte.
@KTibow
Copy link
Contributor Author

KTibow commented Nov 12, 2022

This might be relevant:

prettier-plugin-svelte/src/print/index.ts

Line 433 in ebd7e9a

return concat([node.name, '=', '"', attrNodeValue, '"']);

@dummdidumm dummdidumm added the bug Something isn't working label Nov 18, 2022
@dummdidumm
Copy link
Member

Related to #253

@KTibow
Copy link
Contributor Author

KTibow commented Nov 19, 2022

Yeah I saw that but didn't fully read it, I wouldn't mind if you merged this issue into that one, but I'm fine using this one for tracking separately

@lianghai
Copy link

I’m also affected by this, but have been procrastinating about the bug report… Thanks, OP!

@lianghai
Copy link

Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lianghai @dummdidumm @KTibow