Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Keep parantheses in script tags for which JS is assumed #224

Merged
merged 1 commit into from
May 10, 2021

Conversation

dummdidumm
Copy link
Member

If a script tag is assumed to be JS, use babel-ts now to format the contents. The formatter prints a little different, keeping parantheses in more places, which fixes #218 . The change is not perfect because it would be better to know for sure that the language is JS, which we cannot know because of the possible language defaults.

If a script tag is assumed to be JS, use babel-ts now to format the contents. The formatter prints a little different, keeping parantheses in more places, which fixes sveltejs#218 . The change is not perfect because it would be better to know for sure that the language is JS, which we cannot know because of the possible language defaults.
@dummdidumm dummdidumm merged commit 9d1486e into sveltejs:master May 10, 2021
@dummdidumm dummdidumm deleted the fix-js-parens branch May 10, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSDoc type cast parens are removed
1 participant