(feat) update new typings #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to conform to new on:X and bind:X transformations and to prepare the transition to official html typings
|
Looks good. Can't think of any problem with the plan and code-wise at the moment. But I have an idea to enhance migration. What do you think about we add an information message to the extension? To notify the changes and linking to the feedback or the roadmap thread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to conform to new on:X and bind:X transformations and to prepare the transition to official html typings.
@jasonlyu123 FYI the idea is to test out the new transformation changes the next few days, then flip the switch so everyone get the new transformation, gather feedback, and then publish the typings somewhere official. Anything I may have overlooked as part of this plan?