(feat) preserve bind: in new transformation #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On HTML attributes
5 tasks
|
Looks good. If we understand it correctly we'll have a similar roadmap for this as the event. So we now don't have to update the definition in |
|
Yes, the event PR, this PR, the actions PR and the "remove old JSX typings" PR which is soon to come will all be merged at once after the new Svelte version with the needed changes is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On HTML attributes
@jasonlyu123 this would be needed if we want to switch to explicit
bind:Xtypings in the new transformation - does that look correct to you?