Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) don't ignore .svelte-kit/types in file watch #1566

Merged
merged 2 commits into from Jul 26, 2022

Conversation

jasonlyu123
Copy link
Member

@jasonlyu123 jasonlyu123 commented Jul 23, 2022

#1568 For the generated types for svelte-kit.

Another alternative is to check all the .d.ts files in the ignored build folder. @dummdidumm What do you think is better?

@dummdidumm
Copy link
Member

Right now it doesn't make a difference, but I like your alternative proposal to instead always add snapshots of d.ts files since we probably want to load them - let's change it 👍

@tcc-sejohnson
Copy link
Contributor

tcc-sejohnson commented Jul 26, 2022

Just glanced -- you may want to check the issue I just opened. The type file we're currently generating is .svelte-kit/ambient.d.ts. I don't think this update would pick it up.

Edit: We can probably add it to the types folder if that would significantly simplify things here.

@jasonlyu123
Copy link
Member Author

I updated to check all the declaration files. The reason I proposed the declaration file alternative is it would be more generic so we won't need to update again if kit change the file location. Plus the declaration files usually not that big so it's safer for it to slip.

@dummdidumm dummdidumm merged commit 612a390 into sveltejs:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants