Go to References - Where Imports Used

[Jojoshua]

Initial draft for #1485

[Jojoshua]

I added a better dummy handler for this but every time I load the debugger I see Error: Language client is not ready yet error in the debug console. Any thoughts on what might be wrong?

[Jojoshua]

I added a better dummy handler for this but every time I load the debugger I see Error: Language client is not ready yet error in the debug console. Any thoughts on what might be wrong?

FYI @jasonlyu123 here is the error..

Loading server from [....]\svelte-language-tools\packages\language-server\bin\server.js
packages/svelte-vscode/src/extension.ts:97
rejected promise not handled within 1 second: Error: Connection to server got closed. Server will not be restarted.

I notice that I do not have a server.js file where it is referencing(only a server.ts file). I did a yarn build but that did not create it or I cant find it. Is there a step I am missing to get this setup properly?

[Jojoshua]

I added a better dummy handler for this but every time I load the debugger I see Error: Language client is not ready yet error in the debug console. Any thoughts on what might be wrong?

FYI @jasonlyu123 here is the error..

Loading server from [....]\svelte-language-tools\packages\language-server\bin\server.js packages/svelte-vscode/src/extension.ts:97 rejected promise not handled within 1 second: Error: Connection to server got closed. Server will not be restarted.

I notice that I do not have a server.js file where it is referencing(only a server.ts file). I did a yarn build but that did not create it or I cant find it. Is there a step I am missing to get this setup properly?

@jasonlyu123 I found the issue with this. I had 2 clones and did npm install instead of yarn install. I am not getting this error anymore

[Jojoshua]

@dummdidumm I merged master and noticed this parsing issue. Could you verify this is OK

[Jojoshua]

Added command to menu inside editor as well

[Jojoshua]

This PR now fulfills #1485 and ready for another review. I was pleasantly surprised to see it works with dynamic imports references as well.

[Jojoshua]

@dummdidumm Could you try the build again, I wasn't setup to format with prettier before...as a sidenote, should there be a vscode workspace setting for these packages so that prettier is automatically invoked when saving?

[dummdidumm]

This is great, thank you! Only thing that's missing is a test. You'd create a new test file in test/plugins/typescript/features with setup similar to for example FindReferencesProvider.test.ts and create two testfiles in the adjacent testfiles folder. That's all very cumbersome, so I can do this, too, when I have time.

[Jojoshua]

This is great, thank you! Only thing that's missing is a test. You'd create a new test file in test/plugins/typescript/features with setup similar to for example FindReferencesProvider.test.ts and create two testfiles in the adjacent testfiles folder. That's all very cumbersome, so I can do this, too, when I have time.

Thanks for the initial tip for this. I added 0aded87 which I would expect to work but I am getting no results from the provider.fileReferences call. Ideas?

[Jojoshua]

@jasonlyu123 @dummdidumm I think this is ready for another look. My new test is passing but just FYI there is an unrelated test CompletionProvider.test.ts which is failing locally

[dummdidumm]

Great work, thank you very much!
Out of curiosity: How easy was it for you to contribute / navigate around the code base? Did you notice things would you improve?

[Jojoshua]

Great work, thank you very much! Out of curiosity: How easy was it for you to contribute / navigate around the code base? Did you notice things would you improve?

Thank you @dummdidumm, and I like that you asked this question.

This was very difficult for me to work through, not primarily due to the code base but rather that this domain (tooling for vscode/typescript) is all new to me. The concepts and architecture of how all this works together is complicated. I found a mermaid diagram for the volar project which helped reinforce what @jasonlyu123 was trying to explain to me throughout. https://github.com/johnsoncodehk/volar#high-level-system-overview Possibly a similar diagram for this project's architecture would have helped but there is no perfect replacement for sharing knowledge 1 on 1. Good news is that I know a little bit more than I did two weeks ago. If I had to do it all over again, I wouldn't have as much difficulty.

As for the codebase, minor criticisms

• There is a fair amount of duplicated code
• Debugging didn't work (or wasn't obvious) in all the packages

Things that I would note as helpful in the codebase:

• The instructions in the development section of the readme was clear https://github.com/sveltejs/language-tools#development
• It was easy to build the project
• The preconfigured vscode debug configurations were instrumental