(fix) prevent duplicate import updates #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TS plugin and the Svelte extension want to update the same locations after a file move/rename in some cases; prevent that sveltejs#641
|
I have a commit pending that splits this up a little more robust, only leaving Svelte file Updates out of the TS plugin, not skipping all renames. |
dummdidumm
force-pushed
the
fix-duplicate-import-update
branch
from
060fbca
to
1db960c
Compare
|
Just realized that the second commit might make things worse. If there's a TS file and both a TS and Svelte file is updated (moving a folder), maybe the TS server then operates on outdated ranges, leading to broken imports again. Need to check that when I have time. |
|
@dummdidumm Great work as always on the language tools. They make the Svelte writing experience a lot better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TS plugin and the Svelte extension want to update the same locations after a file move/rename in some cases; prevent that
#1461