Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ambient.d.ts files in adapter packages. #6917

Merged
merged 5 commits into from Sep 21, 2022

Conversation

SG60
Copy link
Contributor

@SG60 SG60 commented Sep 20, 2022

Fixes automatic typing for Cloudflare caches and similar stuff.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Fixes automatic typing for Cloudflare caches and similar stuff.
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2022

🦋 Changeset detected

Latest commit: dffdf12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-auto Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you — we actually don't want the ambient.d.ts files to be included with adapter-netlify, adapter-node and adapter-vercel because they're purely concerned with the adapter innards. but we do want it in the case of adapter-cloudflare and adapter-cloudflare-workers. the distinction could probably be clearer but for now it's easier to just do this

packages/adapter-netlify/package.json Outdated Show resolved Hide resolved
packages/adapter-node/package.json Outdated Show resolved Hide resolved
packages/adapter-vercel/package.json Outdated Show resolved Hide resolved
.changeset/dull-cows-sneeze.md Outdated Show resolved Hide resolved
@SG60
Copy link
Contributor Author

SG60 commented Sep 20, 2022

Ah ok! Sorry, didn't realise that. Thanks for making the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants