Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out node-fetch for undici #5113

Closed
rmunn opened this issue May 30, 2022 · 3 comments · Fixed by #5117
Closed

Swap out node-fetch for undici #5113

rmunn opened this issue May 30, 2022 · 3 comments · Fixed by #5117

Comments

@rmunn
Copy link
Contributor

rmunn commented May 30, 2022

Describe the problem

#4934 had a checklist step "swap out node-fetch for undici, which is more standards compliant (though I think we're blocked on nodejs/undici#1262)". nodejs/undici#1262 has just been closed via nodejs/undici#1469, so it may be time to look again at swapping out node-fetch, at least once nodejs/undici#1469 makes its way into an actual Node release.

Describe the proposed solution

Swap out node-fetch for undici as described in #4934 (comment)

Alternatives considered

No response

Importance

would make my life easier

Additional Information

This should allow us to make progress on #3419 as well (see #4934 (comment)).

@OttoHatt
Copy link
Contributor

I believe this'll be blocked by #5109 (cloudflare wrangler also uses Undici for requests).

@Rich-Harris Rich-Harris mentioned this issue May 30, 2022
9 tasks
@benmccann benmccann linked a pull request May 31, 2022 that will close this issue
9 tasks
@rmunn
Copy link
Contributor Author

rmunn commented May 31, 2022

I believe this'll be blocked by #5109 (cloudflare wrangler also uses Undici for requests).

#5109 is marked as fixed by #5116, which has been released in next.346. I can't confirm that the fix works on Cloudflare as I don't have any Cloudflare sites set up at the moment; @OttoHatt, can you confirm that it works?

@OttoHatt
Copy link
Contributor

yes! on the newest version, #5109 is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants