Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvelteKit 1.0 release blockers in Vite #2086

Closed
benmccann opened this issue Aug 4, 2021 · 1 comment
Closed

SvelteKit 1.0 release blockers in Vite #2086

benmccann opened this issue Aug 4, 2021 · 1 comment
Labels
bug Something isn't working p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc. vite
Milestone

Comments

@benmccann
Copy link
Member

benmccann commented Aug 4, 2021

Update

Vite 2.7 fixed most issues that users faced. If you're having issues with a library please make sure you're using Vite 2.7. If you're still having problems, please file an issue

Describe the bug

SvelteKit apps are no different from any other Vite app from the most part. The unique things that they do are include vite-plugin-svelte and automatically add Svelte component libraries to optimizeDeps.exclude and ssr.noExternal (this latter functionality may be replaced with the experimental.prebundleSvelteLibraries option)

Blockers

vitejs/vite#2579 / vitejs/vite#3024 / vitejs/vite#3910 (prebundling skips .svelte) - experimental solution. see prebundleSvelteLibraries
vitejs/vite#7154 (externalizing of nested deps) - slated for 2.9
#3118 / #3053 (package.json issues) - fixed in 2.8
vitejs/vite#5890 (not externalizing dependency) - fixed in 2.7
vitejs/vite#3953 (resolving packages with exports) - fixed in 2.7
vitejs/vite#5446 (context="module" not scanned in separate scope) - fixed in 2.7
vitejs/vite#4425 (no main - only sub-directories exported. e.g. firebase) - fixed in 2.7
vitejs/vite#5197 (ESM-only deps) - fixed in 2.7
vitejs/vite#4306 (svelte store functions overwritten) - fixed in 2.6.11
vitejs/vite#4699 (can't use SvelteKit-provided libraries - #2237) - fixed in 2.5.3
vitejs/vite#4452 (resolve .cjs, .mjs) - fixed in 2.5.2

Nice-to-have

vitejs/vite#4192 (process.env on server) - fixed in 2.7
vitejs/vite#5193 (allow export default in template) - fixed in 2.6.8
vitejs/vite#5192 (better error messages for parse failures) - fixed in 2.6.4
vitejs/vite#4426 (surface package resolution failures) - fixed in 2.5.1, but partially rolled back (vitejs/vite#4873)
vitejs/vite#4699 (support application/ld+json) - fixed in 2.5
vitejs/vite#2740 (more SSR tests)
vitejs/vite#2830 (CSS sourcemaps)
vitejs/vite#3928 (debugging support)

Reproduction

In individual Vite bugs

Logs

No response

System Info

n/a

Severity

blocking an upgrade

Additional Information

No response

@benmccann benmccann added bug Something isn't working vite labels Aug 4, 2021
@benmccann benmccann added this to the 1.0 milestone Aug 4, 2021
@sveltejs sveltejs locked and limited conversation to collaborators Aug 4, 2021
@benmccann benmccann added the p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc. label Aug 4, 2021
@benmccann benmccann pinned this issue Aug 5, 2021
@benmccann benmccann unpinned this issue Jul 5, 2022
@benmccann
Copy link
Member Author

I'm going to close this now that Vite 3 has been released

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc. vite
Projects
None yet
Development

No branches or pull requests

1 participant