Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add %sveltekit.version% placeholder for template interpolation #12132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add %sveltekit.version% placeholder for template interpolation #12132

wants to merge 1 commit into from
+6 −1

Conversation

potch
Copy link

@potch potch commented Apr 16, 2024

Allow app.html to interpolate the version string passed to kit.version.name in svelte.config.js. This makes it easier for static <head> includes for third-party scripts to be passed the current app version, e.g.

<script>
  GenericAnalytics.init({
    token: "abc123",
    application: "web",
    version: "%sveltekit.version%",
  });
</script>

This is nice ergonomic improvement, but there are several available workarounds:

  • set a variable using a globally included %sveltekit.head%
  • duplicate the version string to an env variable and use %sveltekit.env.PUBLIC_VERSION%
  • do your own pre-templating of app.html in hooks.server

This PR resolves #12130.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2024

⚠️ No Changeset found

Latest commit: 6491007

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a %svelte.version% template placeholder to propagate the current kit.version.name to app.html
1 participant
@potch