From 510ba27c9723d929c9d930a030a909fb064ce461 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sat, 26 Nov 2022 16:21:01 -0800 Subject: [PATCH] better still --- .../kit/test/apps/basics/test/client.test.js | 27 +++++++------------ 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/packages/kit/test/apps/basics/test/client.test.js b/packages/kit/test/apps/basics/test/client.test.js index a9580cc3595e..4bdece527bfa 100644 --- a/packages/kit/test/apps/basics/test/client.test.js +++ b/packages/kit/test/apps/basics/test/client.test.js @@ -608,28 +608,21 @@ test.describe('Load', () => { if (process.env.DEV) { test('using window.fetch causes a warning', async ({ page, baseURL }) => { - /** @type {string[]} */ - const warnings = []; - - page.on('console', (msg) => { - if (msg.type() === 'warning') { - warnings.push(msg.text()); - } - }); - - await Promise.all([page.goto('/load/window-fetch/incorrect'), page.waitForEvent('console')]); - + const [msg0] = await Promise.all([ + page.waitForEvent('console'), + page.goto('/load/window-fetch/incorrect') + ]); expect(await page.textContent('h1')).toBe('42'); - expect(warnings).toContain( + expect(msg0.text()).toBe( `Loading ${baseURL}/load/window-fetch/data.json using \`window.fetch\`. For best results, use the \`fetch\` that is passed to your \`load\` function: https://kit.svelte.dev/docs/load#making-fetch-requests` ); - warnings.length = 0; - - await Promise.all([page.goto('/load/window-fetch/correct'), page.waitForEvent('console')]); - + const [msg1] = await Promise.all([ + page.waitForEvent('console'), + page.goto('/load/window-fetch/correct') + ]); expect(await page.textContent('h1')).toBe('42'); - expect(warnings).not.toContain( + expect(msg1.text()).toBe( `Loading ${baseURL}/load/window-fetch/data.json using \`window.fetch\`. For best results, use the \`fetch\` that is passed to your \`load\` function: https://kit.svelte.dev/docs/load#making-fetch-requests` ); });