diff --git a/.changeset/nine-rivers-argue.md b/.changeset/nine-rivers-argue.md new file mode 100644 index 000000000000..95182b40cf8a --- /dev/null +++ b/.changeset/nine-rivers-argue.md @@ -0,0 +1,5 @@ +--- +'create-svelte': patch +--- + +Upgrade to Playwright 1.28.1 diff --git a/package.json b/package.json index a0db35cd1434..92185bfe9575 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,7 @@ "@rollup/plugin-json": "^5.0.1", "@rollup/plugin-node-resolve": "^15.0.1", "@svitejs/changesets-changelog-github-compact": "^0.1.1", - "playwright": "1.25.0", + "playwright": "^1.28.1", "prettier": "^2.7.1", "rollup": "^2.79.1", "svelte": "^3.52.0", diff --git a/packages/create-svelte/package.json b/packages/create-svelte/package.json index 3094834ca82e..1be40da7a574 100644 --- a/packages/create-svelte/package.json +++ b/packages/create-svelte/package.json @@ -15,7 +15,7 @@ "prompts": "^2.4.2" }, "devDependencies": { - "@playwright/test": "1.25.0", + "@playwright/test": "^1.28.1", "@sveltejs/kit": "workspace:*", "@types/gitignore-parser": "^0.0.0", "@types/prettier": "^2.7.1", diff --git a/packages/kit/package.json b/packages/kit/package.json index cdba312028f6..ea23e8a9d435 100644 --- a/packages/kit/package.json +++ b/packages/kit/package.json @@ -24,7 +24,7 @@ "undici": "5.13.0" }, "devDependencies": { - "@playwright/test": "1.25.0", + "@playwright/test": "^1.28.1", "@types/connect": "^3.4.35", "@types/marked": "^4.0.7", "@types/mime": "^3.0.1", diff --git a/packages/kit/src/runtime/client/fetcher.js b/packages/kit/src/runtime/client/fetcher.js index 552bae15eadd..31cf1567804a 100644 --- a/packages/kit/src/runtime/client/fetcher.js +++ b/packages/kit/src/runtime/client/fetcher.js @@ -26,7 +26,12 @@ if (import.meta.env.DEV) { const url = input instanceof Request ? input.url : input.toString(); const stack = /** @type {string} */ (new Error().stack); - const heuristic = can_inspect_stack_trace ? stack.includes('load_node') : loading; + // check if fetch was called via load_node. the lock method only checks if it was called at the + // same time, but not necessarily if it was called from `load` + // we use just the filename as the method name sometimes does not appear on the CI + const heuristic = can_inspect_stack_trace + ? stack.includes('src/runtime/client/client.js') + : loading; if (heuristic) { console.warn( `Loading ${url} using \`window.fetch\`. For best results, use the \`fetch\` that is passed to your \`load\` function: https://kit.svelte.dev/docs/load#making-fetch-requests` diff --git a/packages/kit/test/apps/basics/test/client.test.js b/packages/kit/test/apps/basics/test/client.test.js index 0e6a69c454d9..8d3c917f7d1a 100644 --- a/packages/kit/test/apps/basics/test/client.test.js +++ b/packages/kit/test/apps/basics/test/client.test.js @@ -608,24 +608,28 @@ test.describe('Load', () => { if (process.env.DEV) { test('using window.fetch causes a warning', async ({ page, baseURL }) => { + await Promise.all([ + page.goto('/load/window-fetch/incorrect'), + page.waitForEvent('console', { + predicate: (message) => { + return ( + message.text() === + `Loading ${baseURL}/load/window-fetch/data.json using \`window.fetch\`. For best results, use the \`fetch\` that is passed to your \`load\` function: https://kit.svelte.dev/docs/load#making-fetch-requests` + ); + }, + timeout: 3_000 + }) + ]); + expect(await page.textContent('h1')).toBe('42'); + /** @type {string[]} */ const warnings = []; - page.on('console', (msg) => { if (msg.type() === 'warning') { warnings.push(msg.text()); } }); - await page.goto('/load/window-fetch/incorrect'); - expect(await page.textContent('h1')).toBe('42'); - - expect(warnings).toContain( - `Loading ${baseURL}/load/window-fetch/data.json using \`window.fetch\`. For best results, use the \`fetch\` that is passed to your \`load\` function: https://kit.svelte.dev/docs/load#making-fetch-requests` - ); - - warnings.length = 0; - await page.goto('/load/window-fetch/correct'); expect(await page.textContent('h1')).toBe('42'); diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 4eac67c0ba83..2ac513e1f084 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -9,7 +9,7 @@ importers: '@rollup/plugin-json': ^5.0.1 '@rollup/plugin-node-resolve': ^15.0.1 '@svitejs/changesets-changelog-github-compact': ^0.1.1 - playwright: 1.25.0 + playwright: ^1.28.1 prettier: ^2.7.1 rollup: ^2.79.1 svelte: ^3.52.0 @@ -22,7 +22,7 @@ importers: '@rollup/plugin-json': 5.0.1_rollup@2.79.1 '@rollup/plugin-node-resolve': 15.0.1_rollup@2.79.1 '@svitejs/changesets-changelog-github-compact': 0.1.1 - playwright: 1.25.0 + playwright: 1.28.1 prettier: 2.7.1 rollup: 2.79.1 svelte: 3.53.1 @@ -199,7 +199,7 @@ importers: packages/create-svelte: specifiers: - '@playwright/test': 1.25.0 + '@playwright/test': ^1.28.1 '@sveltejs/kit': workspace:* '@types/gitignore-parser': ^0.0.0 '@types/prettier': ^2.7.1 @@ -218,7 +218,7 @@ importers: kleur: 4.1.5 prompts: 2.4.2 devDependencies: - '@playwright/test': 1.25.0 + '@playwright/test': 1.28.1 '@sveltejs/kit': link:../kit '@types/gitignore-parser': 0.0.0 '@types/prettier': 2.7.1 @@ -261,7 +261,7 @@ importers: packages/kit: specifiers: - '@playwright/test': 1.25.0 + '@playwright/test': ^1.28.1 '@sveltejs/vite-plugin-svelte': ^1.3.1 '@types/connect': ^3.4.35 '@types/cookie': ^0.5.1 @@ -301,7 +301,7 @@ importers: tiny-glob: 0.2.9 undici: 5.13.0 devDependencies: - '@playwright/test': 1.25.0 + '@playwright/test': 1.28.1 '@types/connect': 3.4.35 '@types/marked': 4.0.7 '@types/mime': 3.0.1 @@ -1059,13 +1059,13 @@ packages: fastq: 1.13.0 dev: true - /@playwright/test/1.25.0: - resolution: {integrity: sha512-j4EZhTTQI3dBeWblE21EV//swwmBtOpIrLdOIJIRv4uqsLdHgBg1z+JtTg+AeC5o2bAXIE26kDNW5A0TimG8Bg==} + /@playwright/test/1.28.1: + resolution: {integrity: sha512-xN6spdqrNlwSn9KabIhqfZR7IWjPpFK1835tFNgjrlysaSezuX8PYUwaz38V/yI8TJLG9PkAMEXoHRXYXlpTPQ==} engines: {node: '>=14'} hasBin: true dependencies: '@types/node': 18.11.9 - playwright-core: 1.25.0 + playwright-core: 1.28.1 dev: true /@polka/url/1.0.0-next.21: @@ -3395,19 +3395,19 @@ packages: find-up: 4.1.0 dev: true - /playwright-core/1.25.0: - resolution: {integrity: sha512-kZ3Jwaf3wlu0GgU0nB8UMQ+mXFTqBIFz9h1svTlNduNKjnbPXFxw7mJanLVjqxHJRn62uBfmgBj93YHidk2N5Q==} + /playwright-core/1.28.1: + resolution: {integrity: sha512-3PixLnGPno0E8rSBJjtwqTwJe3Yw72QwBBBxNoukIj3lEeBNXwbNiKrNuB1oyQgTBw5QHUhNO3SteEtHaMK6ag==} engines: {node: '>=14'} hasBin: true dev: true - /playwright/1.25.0: - resolution: {integrity: sha512-Z+pQNWI17Qx/tHhnmgMmPsptsisXpKgAnUvYv98kctlHUJaqMt2400P8kTw9vEPoC0xdxqu0JhxO7pDTmaaIKw==} + /playwright/1.28.1: + resolution: {integrity: sha512-92Sz6XBlfHlb9tK5UCDzIFAuIkHHpemA9zwUaqvo+w7sFMSmVMGmvKcbptof/eJObq63PGnMhM75x7qxhTR78Q==} engines: {node: '>=14'} hasBin: true requiresBuild: true dependencies: - playwright-core: 1.25.0 + playwright-core: 1.28.1 dev: true /polka/1.0.0-next.22: diff --git a/turbo.json b/turbo.json index 7c05925f5a27..5557ded45408 100644 --- a/turbo.json +++ b/turbo.json @@ -30,6 +30,9 @@ "check": { "dependsOn": ["prepare"], "inputs": [ + "index.js", + "index.d.ts", + "ambient.d.ts", "src/**", "types/**", ".svelte-kit/types/**",