Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit usage of build tags #1403

Open
dave-tucker opened this issue May 3, 2024 · 0 comments
Open

Audit usage of build tags #1403

dave-tucker opened this issue May 3, 2024 · 0 comments
Labels
kind/feature New feature or request tech-debt

Comments

@dave-tucker
Copy link
Collaborator

What would you like to be added?

While working on #1390 I fell into a trap.
Build tags are currently being used to gate:

  • bcc
  • libbpf
  • gpu
  • darwin

Due to the way CI is set up (lint for example) and how tooling like go lint and go vet work it's quite possible that the linters aren't being run on all files - meaning that reviewers will need to be ultra cautious on vetting changes to these files.

Why is this needed?

To ensure everything builds and lints properly it would be a good idea to drop all unnecessary build tags.

Ideally that would include the darwin stubs as this seems to create a lot of work for very little gain - i.e you'd be better building inside a Linux Container on macOS (given this software is macOS specific) than having to maintain a sprawl of stub files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request tech-debt
Projects
None yet
Development

No branches or pull requests

1 participant