Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node version breaking change #138

Closed
jdanil opened this issue Jul 7, 2020 · 3 comments · Fixed by #139
Closed

Node version breaking change #138

jdanil opened this issue Jul 7, 2020 · 3 comments · Fixed by #139

Comments

@jdanil
Copy link

jdanil commented Jul 7, 2020

Releases from 5.0.0-beta-1 include a breaking change to the required node version that isn't documented in the changelog. The package.json engines field was updated to include "node": ">=12.0.0", where previously an engine wasn't specified.

Running install with node 10 returns the following error.

error webpack-merge@5.0.7: The engine "node" is incompatible with this module. Expected version ">=12.0.0". Got "10.21.0"
error Found incompatible module.

Considering that this is an undocumented breaking change and node 10 is still supported until April 2021 (https://nodejs.org/en/about/releases/) I'm wondering if this was a mistake?

@bebraw
Copy link
Member

bebraw commented Jul 7, 2020 via email

@bebraw
Copy link
Member

bebraw commented Jul 7, 2020

I included support for Node 10 to 5.0.8 and added the missing changelog bits. Thanks again!

@jdanil
Copy link
Author

jdanil commented Jul 7, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants