Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getTag() clashes with ticket_tag #50

Closed
bytestream opened this issue Oct 22, 2020 · 1 comment · Fixed by #52
Closed

getTag() clashes with ticket_tag #50

bytestream opened this issue Oct 22, 2020 · 1 comment · Fixed by #52
Assignees

Comments

@bytestream
Copy link
Member

Some method names will clash if we add more end points to the library.

For example:

I guess it would make more sense to call it getSelfserviceTag() ?

Does this sound OK @Gaitholabi ?

@bytestream bytestream changed the title $api->getTag() clashes with ticket_tag getTag() clashes with ticket_tag Oct 22, 2020
@Gaitholabi
Copy link
Collaborator

Sure, this will make it more scaleable on the long term

@Gaitholabi Gaitholabi linked a pull request Oct 24, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants