Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Admission Controller to enforce Namespace Annotations for External Secrets #388

Open
1 of 2 tasks
skomp opened this issue Dec 3, 2021 · 2 comments
Open
1 of 2 tasks
Labels
enhancement New feature or request stale
Projects

Comments

@skomp
Copy link
Member

skomp commented Dec 3, 2021

We don't currently set any namespace annotations for external secrets but should provide a sensible default.

Use Case

When adding a namespace, we should automatically add a namespace annotation for external secrets with a proper scope to a path in the AWS Secrets Manager.

Proposed Solution

Implement an admission controller that whenever a namespace is created, attaches an annotation for external secrets and also checks that no more external secrets annotations are added. For instance, when creating namespace a, an external secrets annotation to give access to secrets with the prefix /k8s/a/.* as well as an annotation allowing for global secrets, e.g., /k8s/global/.*.

Other

This might serve as an inspiration: https://aws.amazon.com/blogs/containers/building-serverless-admission-webhooks-for-kubernetes-with-aws-sam/

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@skomp skomp created this issue from a note in 1.0 (To do) Dec 3, 2021
@skomp skomp added the enhancement New feature or request label Dec 3, 2021
@github-actions
Copy link

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

@github-actions github-actions bot added the stale label Dec 18, 2021
@github-actions
Copy link

Closing this issue as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen.

1.0 automation moved this from To do to Done Dec 20, 2021
@Miradorn Miradorn reopened this Dec 20, 2021
1.0 automation moved this from Done to To do Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
1.0
  
To do
Development

No branches or pull requests

2 participants