Skip to content

Latest commit

 

History

History
97 lines (70 loc) · 4.06 KB

CONTRIBUTING.md

File metadata and controls

97 lines (70 loc) · 4.06 KB
Raw

Contributing to super-eks

(Proudly copied from projen)

Thanks for your interest in contributing to super-eks! ❤️

This document describes how to set up a development environment and submit your contributions. Please read it carefully and let us know if it's not up-to date (or even better, submit a pull request with your corrections! 😉).

Pre-requisites

Manually install tools

The following tools need to be installed to develop on super-eks locally.

Getting Started

The basic commands to get the repository cloned and built locally follow:

git clone git@github.com:superluminar/super-eks
cd super-eks
npm i # install dependencies
npm run build# build super-eks

Development workflow

The super-eks package has the following scripts:

  • build - builds the package and runs all unit tests
  • watch - watches for file changes and builds them progressively
  • test - executes all unit tests
  • test:update - exectes all unit tests and overwrites snapshot expectations (those .snap files).
  • test:watch - runs all unit tests and reruns tests when files are changed
  • package - emits publishable artifacts to dist.
  • eslint - run linter against source code

Each of these scripts can be executed using npm run <script> or npx projen <script>.

Tests are located under test and executed from javascript code, so make sure to compile once before running any tests.

One trick for quickly iterating is to run npm run watch in one terminal, and npm run test:watch in another. Then, when you change your unit tests the code will automatically recompile, thus triggering the tests to automatically re-run.

Linting & Formatting

Eslint is used to lint and format our typescript code. The eslint script can be run from the root of the package.

You can integrate the linting and formatting workflow with your editor or ide by installing the approporiate eslint plugin. For example, when using Visual Studio Code, the eslint plugin exposes a number of options including "fix on save". This will auto correct lint and formatting errors whenever possible while saving a document.

Version bumping

Currently super-eks does not bump versions automatically. A new release can be triggered from the GitHub Actions Page. super-eks follows semantic versioning through the standard-version npm utility.

Making a pull request

  • Commit title and message (and PR title and description) must adhere to conventionalcommits.
    • The title must begin with feat(module): title, fix(module): title, refactor(module): title or chore(module): title, where the module refers to the projects or components that the change centers on. The module can be omitted, so "feat: title" is okay as well.
    • Title should be lowercase.
    • No period at the end of the title.
  • Commit message should describe motivation. Think about your code reviewers and what information they need in order to understand what you did. If it's a big commit (hopefully not), try to provide some good entry points so it will be easier to follow.
  • Commit message should indicate which issues are fixed: fixes #<issue> or closes #<issue>.
  • Shout out to collaborators.
  • If not obvious (i.e. from unit tests), describe how you verified that your change works.
  • If this commit includes breaking changes, they must be listed at the end in the following format (notice how multiple breaking changes should be formatted):
BREAKING CHANGE: Description of what broke and how to achieve this behavior now
* **module-name:** Another breaking change
* **module-name:** Yet another breaking change

Merging

Once your PR builds and has at least one approving review mergify should automatically merge it.