Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users migrating from --region to --regions will cause having old images keep running #3551

Open
remorses opened this issue May 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@remorses
Copy link

remorses commented May 16, 2024

Recently flyctl removed --region and renamed --only-regions to --regions in #3514, this will cause many users to try to migrate --region to --regions (as i did myself).

This migration is very dangerous, the behaviour is completely different and will cause having machines with older image versions running side by side with the new machines.

Imagine what someone that was previously using --region may do when the flag is no longer working:

  1. User tries to deploy, --region no longer works
  2. Finds the new --regions flag, just replaces it
  3. The user passes a new region in this flag thinking the command will simply deploy machines in that region, like it did previously
  4. The command instead only runs the deployment ignoring regions not passed to --regions, causing the old machines to keep running with the old image version, possibly breaking production

In my opinion --regions should be changed back to --only-regions. I don't think having old versions of the Docker image keep running in other regions is something many people want, it will cause hard to debug issues where old application code keeps running in a non deterministic way.

Also related to #3537 and #3509

@remorses remorses added the bug Something isn't working label May 16, 2024
@remorses remorses changed the title Users migrating from --region to --regions will cause having old image machines keep running Users migrating from --region to --regions will cause having old images keep running May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant