Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metric: histogram for image push duration #3103

Open
tvdfly opened this issue Dec 8, 2023 · 3 comments
Open

New metric: histogram for image push duration #3103

tvdfly opened this issue Dec 8, 2023 · 3 comments
Labels
bug Something isn't working good first issue registry

Comments

@tvdfly
Copy link
Collaborator

tvdfly commented Dec 8, 2023

Add a new metric that records how long we spend pushing the docker image to our registry during fly deploy. This will help us understand regional variations and overall performance of this action and inform registry performance work.

Potential attributes:

  • builder type: local, remote
  • builder region: for local use the closest region (e.g. where a request hits the fly-proxy edge), for remote use the remote builder machine's region
@tvdfly tvdfly added bug Something isn't working good first issue registry labels Dec 8, 2023
@ziscky
Copy link

ziscky commented Dec 12, 2023

Hey @tvdfly I would love to work on this. I can see some metrics being recorded here
Any pointers ?

@tvdfly
Copy link
Collaborator Author

tvdfly commented Dec 21, 2023

Yep, the metrics.StartTiming() call will likely work here. We use it in a handful of places in the codebase that are good references: https://github.com/search?q=repo%3Asuperfly%2Fflyctl%20metrics.StartTiming&type=code

@utkarsh-shrivastav77
Copy link

Hi can I work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue registry
Projects
None yet
Development

No branches or pull requests

3 participants