Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to set --build-arg #4

Open
callumlocke opened this issue Jun 8, 2022 · 3 comments · May be fixed by #50
Open

Ability to set --build-arg #4

callumlocke opened this issue Jun 8, 2022 · 3 comments · May be fixed by #50

Comments

@callumlocke
Copy link

When I deploy, I have to use --build-arg to set an environment variable that needs to be present on the builder during build, like this:

fly deploy --remote-only --build-arg DATABASE_URL="postgres://..."

Is there any way to set this when using this GitHub Action?
@jsierles
Copy link
Member

jsierles commented Jun 8, 2022

We'd have to add this behavior. PRs are welcome! Maybe it would be useful to allow specifying arbitrary arguments to fly deploy. Also I thought it might be useful to clone secrets from the source app.

I'm curious - why do you need access to the database at build time? One downside with this approach - credentials are stored in the image permanently, posing a security risk. We're working on adding support for build-time secrets to flyctl.

@jsierles
Copy link
Member

jsierles commented Jun 9, 2022

Related - flyctl release v0.0.333 supports passing build secrets on the command line.

@kishanhitk
Copy link

kishanhitk commented Mar 14, 2024 •
edited

Any updates on this?

I want to set --build-secret.

I tried the secrets option, but it sets the runtime secret, and not --build-secret.

@fredericrous fredericrous linked a pull request Mar 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --build-arg and --build-secret frontjutsu/fly-pr-review-apps
3 participants
@jsierles @callumlocke @kishanhitk