Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supabase auth interface missing informiation #30

Closed
zlwaterfield opened this issue Sep 1, 2020 · 1 comment · Fixed by #50
Closed

Supabase auth interface missing informiation #30

zlwaterfield opened this issue Sep 1, 2020 · 1 comment · Fixed by #50
Labels
bug Something isn't working

Comments

@zlwaterfield
Copy link
Contributor

Bug report

Describe the bug

The Supabase auth object has keys on it like the accessToken, supabaseKey, authUrl, etc. which are missing from the Typescript interface definition: https://github.com/supabase/supabase-js/blob/master/src/index.d.ts#L92

Existing keys:

    signup: (email: string, password: string) => Promise<SupabaseAuthResponse>
    login: (email: string, password: string) => Promise<SupabaseAuthResponse>
    user: () => Promise<SupabaseAuthUser>
    logout: () => Promise<void>

Keys to be added:

	accessToken: string
	authHeader: () => {…}
	authUrl: string
	autoRefreshToken: boolean
	callRefreshToken: () => {…}
	currentUser: SupabaseAuthUser
	persistSession: boolean
	recoverSession: () => {…}
	refreshToken: string
	removeSavedSession: () => {…}
	saveSession: () => {…}
	supabaseKey: string
@zlwaterfield zlwaterfield added the bug Something isn't working label Sep 1, 2020
@kiwicopple
Copy link
Member

FYI, this will be corrected when we integrate our new gotrue-js library

spec is being developed here: https://deploy-preview-210--supabase.netlify.app/ref/gotrue/signup/

kiwicopple added a commit that referenced this issue Nov 2, 2020

- Fixes #32 Major DX change: response and error handling
- Fixes #49 When no `supabaseKey` is passed in it throws an error
- Fixes #31 chore: set up semantic releases
- Fixes #15 `supabase.auth.logout()` throws "Invalid user" error.
- Fixes #20 Auth: Change DX of user management
- Fixes #30 Supabase auth interface missing informiation
- Fixes supabase/supabase#147 supabase/supabase#147
- Partial fix for supabase/realtime-js#53  - if there is no token provided. The error needs to be caught at a socket level.
- Adds magic links


## BREAKING CHANGES

- See all breaking changes in RELEASE.md v1.0.0
- Errors are now returned and not thrown
- Auth now uses `@supabase/gotrue-js` interface
- `supabase.getSubscriptions()` only returns open subscriptions



* Updates the config

* chore: Migrates the basic outline to TS

* Adds a simple example showing how it can be used.

* chore: Moves tests to jest

* chore: Adds semantic releases

* Moves the subscription into it's own class

* Updates the todo readme with simple instructions

* Updates installs

* Revverts commented code - sorry for the spam

* docs: adds JSDoc to some functions

* chore: Adds a function for backwards compat

* chore: migrates the client to SupabaseClient

* This change attempts to make the naming conventions the same as Thor's previously

* Updates GoTrue to latest version

* Adds generic type to the from, and updates the name of the query builder

* Updates to latest versions of all packages

* Updates the example to make sure it's working

* Refactor SupabaseQueryBuilder

* Adds prettier hook

* Add TypeScript next.js example.

* Declutter SupabaseClient and make work with gotrue-js changes.

* Bumps the GoTrue version

* Bumps postgrest to include the types

* Temporarily adds the spec so that I can use it in our docs

* Update examples and add resetPassword.

* Bump gotrue-js version.

* Update lockfile.

* Add auth magic link capabilities.

* Gotrue-js user and session method updates.

* chore: Adds release notes

Co-authored-by: Thorsten Schaeff <thorsten.schaeff@gmail.com>
Co-authored-by: Thor 雷神 Schaeff <5748289+thorwebdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants