chore: fix CI release process #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soedirgo
reviewed
Sep 22, 2021
.releaserc.json
Outdated
Comment on lines
19
to
22
| successComment: false, | ||
| releasedLabels: false, | ||
| failTitle: false, | ||
| addReleases: false, |
There was a problem hiding this comment.
Invalid JSON? Should be quoted
inian
approved these changes
Sep 22, 2021
|
How about using Node 14? Since we're using that across the board and 16 isn't LTS.
+1, can be pinned to 18 |
|
done, untested though since in my other repos I've used node16. Works in theory |
soedirgo
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could pin to the last major release of semantic release to avoid bumping node versions for a little while.