Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding error codes to ApiError #915

Open
samirergaibi opened this issue Feb 6, 2022 · 30 comments
Open

Adding error codes to ApiError #915

samirergaibi opened this issue Feb 6, 2022 · 30 comments
Labels
enhancement New feature or request

Comments

@samirergaibi
Copy link

samirergaibi commented Feb 6, 2022

Feature request

Is your feature request related to a problem? Please describe.

I am building a website with supabase and the errors that is returned from supabase.auth only contains a general error code 400 and a message in english. This makes the different errors hard to distinguish from eachother.

Example:
User tries to create an account but the user is already registered so the error returned from supabase.auth.signUp will be

{ 
  message: "User already registered",
  status: 400
}

Describe the solution you'd like

If the error included a specific error code mapped to particular error then providing a custom message would be easy.

Example:

{ 
  message: "User already registered",
  status: 400,
  errorCode: 1,
}

It would also be really awesome if the error codes was included in the documentation.

Describe alternatives you've considered

I've considered checking the string value returned in the error but if that would change in the future that would in turn break the application.

@samirergaibi samirergaibi added the enhancement New feature or request label Feb 6, 2022
@joeyTedeschi
Copy link

+1 for this change, as at this time distinguishing between errors (and translating them to different languages), is completely contingent on parsing the message being returned (and if that message one day got changed, it would break whatever logic we've had to build on top of it)

@salazarr-js
Copy link

I realize that when a user signs up using an already in use email don't get any error messages, auth.signUp() just returns the user. i think in this case i wanna cath the error and tell the user that email is in use

a User already registered error message would be awesome

@Andrewjeska
Copy link

I want to alert the user if they need to check their email for the invite link, so error code would be help on signIn here would really help

@aiji42
Copy link

aiji42 commented Sep 29, 2022

I strongly support this request!
Error codes would facilitate the creation of dictionary data for translation and help with multilingualization.

I am developing an application for Japanese and currently there is no list of error messages, so I am having a hard time creating dictionary data.

@florianwalther-private
Copy link

+1 on this. How am I supposed to provide the user additional steps if their login attempt errors because their email hasn't been verified yet, but they can't find the verification code anymore?

@silentworks
Copy link

Related to supabase/supabase#12739

@nickreese
Copy link

Interested in this.

@inian inian transferred this issue from supabase/supabase Jan 25, 2023
@raheemja
Copy link

raheemja commented Mar 2, 2023

Over a year later and this has not been addressed. I thought features like this were standard practice.

@renansoares
Copy link

no news on this? how people are handling authentication errors and internalization?

@sharifbubuka
Copy link

Thought this was industry standard and not something to implement upon request. Any developments on this?

@otyang
Copy link

otyang commented Apr 2, 2023

This just made ditch supabase Auth for something else.

Its standard practise to return proper errors.

But till now over a year nothing has been done. There is no proper CURL documentation for us to implement the rest Auth into a SDK ourselves.

Even on the little examples, errors are not treated well. this is a no no for me,shows an unserious company in this aspect

@AdamEisfeld
Copy link

+1 on this

@joeldomke
Copy link

I ran into the same issue and started collecting possible error messages by going through the GoTrue implementation.

I collect the errors for each endpoint in this Google Sheets doc. It's WIP so everything in this sheet is a little bit messy at the moment.

I also created a npm package that offers an error handler method for each function of GoTrue JS and therefore also Supabase JS.

@caipicoder
Copy link

caipicoder commented Jul 3, 2023 via email

@drummerjolev
Copy link

Running into the same issue – would love to have standardized error codes for auth (I'm using supabase.auth.signInWithOtp() specifically). Firebase has a doc about this: https://firebase.google.com/docs/reference/js/v8/firebase.auth.Error

@CharleeWa
Copy link

+1 on this

@mwoss
Copy link

mwoss commented Sep 11, 2023

Such improvement would be great for developer experience, +1 to this idea.

@elglogins
Copy link

Any progress on this would be great help! Is there a way we can contribute ourselves?

@bielcarpi
Copy link

+1, Firebase has these standard error codes and it really is essential if you want to, for example, translate the messages

@mashwishi
Copy link

+1, it's hard to use registration/signin manually with react native development using supabase lib, i am a js/ts library user but i would recommend having code status too...

I have already created feature request since Sept but no one have ever response to it

@Ianduha13
Copy link

+1 on this, an error code it would be great to distinguish between errors and then we can make our own internationalization, but using a switch inside an effect its no option for a first class product, if we want to scale to millions we need that feature.
By the way all the good vibes to the supabase team, you're making a incredible work, with my team recently started a new project integrating it with next.js 14 and we are amazed.

@Soren-365
Copy link

Over a year later and this has not been addressed. I thought features like this were standard practice.

They have been busy with the unusable AI bs.

@dannyraede
Copy link

+1. Why is this not a standard already?

@qaynam
Copy link

qaynam commented Feb 17, 2024

It's been two years and still no update?

@mashwishi
Copy link

It's been two years and still no update?

@SamiChab
Copy link

This is an essential feature. +1 to this

@262hz
Copy link

262hz commented Mar 13, 2024

Really, the lack of support for this is disappointing.

Being able to process errors in order to show users a customized (or localized) message is an essential feature.

@haydn
Copy link

haydn commented Mar 14, 2024

@SamiChab @262hz Looks like the PR for this has been merged just recently:

#1377

I believe it's in a release candidate at the moment.

@mashwishi
Copy link

It was already merged but i think its's for auth-js only is it different from supabase-js using supabase.auth?

is this only for auth-js ? and supabase-js not included?

            const response = await supabase.auth.signInWithPassword({
                email: email,
                password: password,
            })

image
Version: "@supabase/supabase-js": "^2.41.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests