Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valuable adoption #452

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Valuable adoption #452

wants to merge 3 commits into from

Conversation

sunng87
Copy link
Owner

@sunng87 sunng87 commented Jul 3, 2021

Fixes #440

Changes to be included:

  • Update Context API to hold a borrowed reference of any T: Valuable, currently it owns a converted serde_json::Value
  • Update Registry render apis to accept T: Valuable instead of serde::Serialize
  • Update internal type system from serde_json::Value to valuable::Value or a hybrid solution. valuable::Value can not hold owned data makes it difficult to cover the derived value during rendering
  • Context navigation API needs to be updated to use Valuable access APIs.
  • update modules related to rhai for exchange between Valuable and Dynamic

@sunng87 sunng87 added this to the 5.0 milestone Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Valuable as the type system
1 participant