Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valuable as the type system #440

Open
sunng87 opened this issue May 29, 2021 · 1 comment · May be fixed by #452
Open

Valuable as the type system #440

sunng87 opened this issue May 29, 2021 · 1 comment · May be fixed by #452
Milestone

Comments

@sunng87
Copy link
Owner

sunng87 commented May 29, 2021

Introduction to valuable

Valuable solve the problem of our data container. Currently by converting data into serde_json::Value, it has to be fully copied. According to our large_loop_helper benchmark, it takes 50% of time in that case.

@sunng87 sunng87 added this to the 5.0 milestone Jun 28, 2021
@sunng87
Copy link
Owner Author

sunng87 commented Jul 3, 2021

changes to adopt Valuable:

  • Update Context API to hold a borrowed reference of any T: Valuable, currently it owns a converted serde_json::Value
  • Update Registry render apis to accept T: Valuable instead of serde::Serialize
  • Update internal type system from serde_json::Value to valuable::Value, since valuable has more types than JSON, we may need to map between these types. Changes will happen in value
  • Context navigation API needs to be updated to use Valuable access APIs.
  • update modules related to rhai for exchange between Valuable and Dynamic

moved to #452

@sunng87 sunng87 linked a pull request Jul 3, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant