Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor call_inner default implementation #437

Merged
merged 4 commits into from May 24, 2021

Conversation

sunng87
Copy link
Owner

@sunng87 sunng87 commented May 23, 2021

This patch changes default implementation of call_inner from HelperDef, and remove unneeded Option from return type.

It tries to fix twice-call issue reported in #435 because developer may return Ok(None) when they actually want to return Json Null. Previously Ok(None) is a special value to indicate the call_inner function is not implemented. This patch changed this and avoid misleading.

@sunng87 sunng87 merged commit ab7eb21 into master May 24, 2021
@sunng87 sunng87 deleted the refacor/call_inner_provided branch May 24, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant