Invalid syntax if (even an escaped) \ is the last character in quotes

[YannikSc]

When defining a string in a template, which contains a \ as last character (even escaped as "\\") the renderer fails with an InvalidSyntax error.

Not sure if this is an intended behaviour, but it definitly feels like a bug and is also not the case in other parsers (like handlebars.js). Sorry if there is already another topic describing this, I have'nt found it.

here is an example which reproduces the bug:

#[macro_use]
extern crate handlebars;

use std::collections::BTreeMap;
use handlebars::Handlebars;

handlebars_helper!(replace: |input: str, from: str, to: str| {
    input.replace(from, to)
});

// Error when having a \ as last character in a string
fn main() {
    let data = BTreeMap::<String, String>::new();
    let mut bars = Handlebars::new();
    bars.register_helper("replace", Box::new(replace));

    // Replace a / with a \

    // Works with "\\ " (if the character, before the quote is not a "\" )
    println!("{}", bars.render_template(r#"{{replace "some/path" "/" "\\ " }}"#, &data).unwrap()); // works
    println!("{}", bars.render_template(r#"{{replace "some/path" "/" "\\something else" }}"#, &data).unwrap()); // works

    // Fails otherwise
    println!("{}", bars.render_template(r#"{{replace "some/path" "/" "\\" }}"#, &data).unwrap()); // fails
    println!("{}", bars.render_template(r#"{{replace "some/path" "/" "something before \\" }}"#, &data).unwrap()); // fails
}

[sunng87]

These seems to be affected by how we deal with escape in json. It works with the original javascript version. Let me investigate.

[sunng87]

@YannikSc the fix is available in 3.5.4