Add CMSG macros #37
Merged
Add CMSG macros #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
reviewed
Dec 7, 2022
There was a problem hiding this comment.
Looks good! I think you're right, that having the CMSG_* equivalents live in this crate makes sense.
In case it's helpful, there was someone working on sendmsg/recvmsg in rustix earlier, but they didn't finish it; the work-in-progress branch is here: https://github.com/bytecodealliance/rustix/tree/sunfishcode/feat-send-recv-msg
That branch likely needs some merge conflict resolution at this point, and probably other work, so I don't know if it's better to start from there or to start new; you're welcome to do either.
sunfishcode
reviewed
Dec 7, 2022
|
@sunfishcode Are there any blockers to merging this PR? |
|
Ah, no, it looks good, I just didn't see the latest patches :-). |
|
Published in 0.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CMSG macros based off of the ones found here. I want to add
sendmsg/recvmsgto Rustix, but I'd rather not deduplicate these functions there.