-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nested global blocks #7423
Fix nested global blocks #7423
Conversation
91b5afa
to
24a62ea
Compare
24a62ea
to
2e6722d
Compare
Now when I expand a global block type the list of properties is empty. |
2e6722d
to
b364f46
Compare
@mamazu seems to work for me pretty well: Have you rebuild the admin dist files? |
b364f46
to
027e9d5
Compare
@mamazu see comment in the issue #7409 (comment) |
Yes. Oddly there are also no console errors this time when I expand a block which is empty. So no clue what's happening. |
@mamazu does it work now? |
@wachterjohannes I also get no console errors now, bus still does not work. |
@spackmat only to be clear - after updating the vendor to my branch - you have to remove the node_modules folder and run |
@wachterjohannes Still no change. Even ran the Sulu admin build update command. |
Works for me, but there is an error with local and global blocks combined: |
@wachterjohannes did it all again for you, still the same: When the blocks are within a section, there are no fields displayed. Outside of a section it works well for normal blocks, nested blocks do not work at all, showing the wrong name. Looks like this (opened), when within a section: And should look like this (when outside of a section: And looks like this (without section) for nested blocks: |
@wachterjohannes @mamazu Hey, the non nested blocks within sections do work now 👏 The nested blocks still fail the same way as before. |
@wachterjohannes with your last commit, the nested blocks also work. Nice! 😎 |
8245859
to
63c4c76
Compare
@wachterjohannes Looks good - even with nested blocks. Thank you! :) |
src/Sulu/Bundle/AdminBundle/Tests/Functional/Controller/AdminControllerTest.php
Outdated
Show resolved
Hide resolved
Works for me. |
056ac38
to
93255ef
Compare
src/Sulu/Bundle/AdminBundle/Tests/Functional/Controller/AdminControllerTest.php
Outdated
Show resolved
Hide resolved
93255ef
to
2086242
Compare
Thank you all for testing! |
What's in this PR?
This PR fixed following issues:
Why?
This issues where introduced by #7229