Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NavigationItems with absolute url configuration #5207

Open
lightglitch opened this issue Apr 11, 2020 · 8 comments · May be fixed by #6328
Open

Support NavigationItems with absolute url configuration #5207

lightglitch opened this issue Apr 11, 2020 · 8 comments · May be fixed by #6328
Labels
Feature New functionality not yet included in Sulu

Comments

@lightglitch
Copy link
Contributor

lightglitch commented Apr 11, 2020

Problem description

I want to add menu items that point to external services in the cms admin menu.

@lightglitch lightglitch added the Feature New functionality not yet included in Sulu label Apr 11, 2020
@alexander-schranz
Copy link
Member

@lightglitch This is supported: You create a new item in the page tree save it and change the type from page to external and enter the url.

external-link

@lightglitch
Copy link
Contributor Author

lightglitch commented Apr 11, 2020

@alexander-schranz I'm not referring to menu options for the website but in the admin sidebar menu when using the Extend Admin tutorial.

Sorry if I didn't explain myself correctly.

@danrot danrot added the To Discuss The core team has to decide if this will be implemented label Apr 14, 2020
@danrot
Copy link
Contributor

danrot commented Apr 14, 2020

Not sure if we really want to support that... The menu on the left only navigates within our SPA at this point, that's a metapher that would break if we are implementing this. At least we would have to implement a visible indicator, that makes clear that a click on that menu item would make you leave our SPA.

@lightglitch
Copy link
Contributor Author

The new option would make the menu more flexible and the visible indicator could be an icon like this https://vectorified.com/new-window-icon

@chirimoya
Copy link
Member

If we add a visual indicator I'm fine with adding this feature.

@danrot danrot removed the To Discuss The core team has to decide if this will be implemented label Apr 14, 2020
@niklasnatter niklasnatter added the Easy Pick Relatively easy to solve for newcomers as well label Oct 30, 2020
@sebheitzmann
Copy link

I have a similar need for one of my website. Maybe we could add an url in the NavigationItem and handle this in the react code ? Of we could make a new "redirectView" that could be redirect to any url in parameters ?

@alexander-schranz
Copy link
Member

Hello @sebheitzmann,

I think it make sense to implement external links in the Admin Navigation. But I personally would not implement them as redirectView, instead I would go with a navigationItemType or new ExternalNavigationItem class. This allows us to add a icon to it to mark it as a external url. Which is the best way to implement this in the frontend need to be checked, but for our point of view it make sense to have them.

@sebheitzmann
Copy link

Ok for the ExternalNavigationItem. I think it's a good idea. Let met propose a pull request.

sebheitzmann added a commit to 2lenet/sulu that referenced this issue Oct 29, 2021
@sebheitzmann sebheitzmann linked a pull request Oct 29, 2021 that will close this issue
1 task
sebheitzmann added a commit to 2lenet/sulu that referenced this issue Oct 29, 2021
@alexander-schranz alexander-schranz removed the Easy Pick Relatively easy to solve for newcomers as well label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included in Sulu
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants