Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable files panel when selecting no #3532

Merged
merged 8 commits into from
May 23, 2024
Merged

Conversation

lwrubel
Copy link
Contributor

@lwrubel lwrubel commented May 14, 2024

Why was this change made? 馃

Resolves #3505. HOLD for testing in deployed env and by PO. Please squash when merging!

Screenshot 2024-05-21 at 4 16 06鈥疨M

How was this change tested? 馃え

Locally, deployed to QA for PO testing

Does your change introduce accessibility violations? 馃┖

No new ones

@lwrubel lwrubel changed the title [HOLD] Disable files panel when selecting no [WIP] Disable files panel when selecting no May 14, 2024
@lwrubel lwrubel force-pushed the t3505-disable-files branch 4 times, most recently from 2ba7087 to ea87e1f Compare May 20, 2024 12:32
@lwrubel lwrubel changed the title [WIP] Disable files panel when selecting no [HOLD] Disable files panel when selecting no May 21, 2024
@lwrubel
Copy link
Contributor Author

lwrubel commented May 22, 2024

Bug 1:
@amyehodge has found a problem with attached files that I think is related to initially saving a draft with neither Yes/No select.

  1. Edit a deposited work
  2. Don't select Yes or No. Save the draft
  3. Edit it again and select Yes. Add a file.
  4. HB error: https://app.honeybadger.io/projects/55564/faults/100610329

I am not sure yet of the source of the error, but I think it has to do with the use_previous_attached_files method in the base_work_form.rb and it attaching (empty?) files that are empty when checksummed later.

I am not sure why we removed logic to require users to select Yes/No even when creating a draft. It seems like that would be good to do anyway, to avoid having a nil new_user_version param saving nil user_version numbers into the work_version.

Bug 2
If you don't select Yes/No, save the draft, and then re-open the draft, the previous version's version description is getting displayed:

Screenshot 2024-05-22 at 4 29 15鈥疨M

@lwrubel
Copy link
Contributor Author

lwrubel commented May 22, 2024

I made a change in the last commit to require users to select Yes/No for a new version even in draft mode. Forcing a selection seems to prevent the bugs above, pending further testing in QA. The styling could use a tweak (see below) to be bolder.

If this does not match with the desired UX, we will need to find a different solution.

Screenshot 2024-05-22 at 5 50 00鈥疨M

@justinlittman justinlittman changed the title [HOLD] Disable files panel when selecting no Disable files panel when selecting no May 23, 2024
@justinlittman justinlittman merged commit 163a449 into main May 23, 2024
7 of 9 checks passed
@justinlittman justinlittman deleted the t3505-disable-files branch May 23, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable files section when user selects to not create a new version
2 participants