-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable files panel when selecting no #3532
Conversation
2ba7087
to
ea87e1f
Compare
ea87e1f
to
29c3667
Compare
Bug 1:
I am not sure yet of the source of the error, but I think it has to do with the I am not sure why we removed logic to require users to select Yes/No even when creating a draft. It seems like that would be good to do anyway, to avoid having a nil Bug 2 |
2877593
to
896cc97
Compare
I made a change in the last commit to require users to select Yes/No for a new version even in draft mode. Forcing a selection seems to prevent the bugs above, pending further testing in QA. The styling could use a tweak (see below) to be bolder. If this does not match with the desired UX, we will need to find a different solution. |
Why was this change made? 馃
Resolves #3505. HOLD for testing in deployed env and by PO. Please squash when merging!
How was this change tested? 馃え
Locally, deployed to QA for PO testing
Does your change introduce accessibility violations? 馃┖
No new ones