Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs found during automated testing #145

Open
lastmjs opened this issue Jul 31, 2021 · 0 comments
Open

Bugs found during automated testing #145

lastmjs opened this issue Jul 31, 2021 · 0 comments

Comments

@lastmjs
Copy link
Contributor

lastmjs commented Jul 31, 2021

These are bugs that were discovered during the initial testing process. I want to keep this here to prove the effectiveness of the original Sudograph tests, and of automated testing as a worthwhile endeavor.

  1. JSON scalars were completely broken for candid serialization
  2. Updating the nullable side of a one-to-one relationship should not be allowed...basically we need to implement foreign key constraints
  3. Leaving out input did not allow object type information to be initialized in the database (relation one?)
  4. Leaving out input did not allow object type information to be initialized in the database for relation many
  5. Made me rethink throwing an error if the offset it too big, now gracefully returns empty (I think that is the better choice)
  6. or was not working correctly, if there is nothing in the or then I think it should return true, not false
  7. ors were being or'd within the field input thing, we needed to get rid of the flat_map
  8. read_input was not returning empty read inputs when relation one had no values inside
  9. Searching for null relations doesn't work properly
  10. I forgot to add startsWith and endsWith to the search within selection sets in Sudograph generate
  11. Search within relation sets was pretty broken...no null values were allowed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant