Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #2

Open
suchipi opened this issue Jun 27, 2018 · 0 comments
Open

Windows support #2

suchipi opened this issue Jun 27, 2018 · 0 comments

Comments

@suchipi
Copy link
Owner

suchipi commented Jun 27, 2018

It'd be nice to support windows, too. I think the only incompatible code is in Job#run:

  • These should use the path module instead of template literals:

const jobDir = `jobs/${taskName}/${commitSha}`;

  • We shouldn't use sh to spawn the process on windows:

"sh",

I'm not sure if windows can run eg. ./quinci/master, it might have to run ./quinci/master.bat or etc.

Also we'd be assuming that git is in the PATH on windows, just like we do for unix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant