Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Update Dependencies #6 #344

Closed
achiurizo opened this issue Sep 27, 2022 · 4 comments
Closed

Update Dependencies #6 #344

achiurizo opened this issue Sep 27, 2022 · 4 comments
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@achiurizo
Copy link
Contributor

achiurizo commented Sep 27, 2022

馃搵 slack audit #6

We should update the dependencies listed from the Audit see

@achiurizo achiurizo added the good first issue Good for newcomers label Sep 27, 2022
@achiurizo achiurizo added this to the Audit Fixes milestone Sep 27, 2022
@achiurizo achiurizo changed the title Update Dependencies Update Dependencies #6 Sep 27, 2022
@isSerge
Copy link
Contributor

isSerge commented Sep 28, 2022

@ozgunozerk
Copy link
Contributor

ozgunozerk commented Oct 3, 2022

  • time: for time dependency, we don't need to fix it. In summary, time package is only used by chrono in our dependency tree. And chrono does not use the vulnerable part of the time crate. CVE-2020-26235 advisory for time 0.1 dependency聽chronotope/chrono#602 (comment)
    In the upcoming release of chrono, they will get rid of time.

  • owning_ref: The same goes for owning_ref, the prometheus dependency in our substrate fork, does not use the vulnerable part of the owning_ref. And soon, it will be upgraded to a newer version of prometheus, which does not use owning_ref.

@isSerge
Copy link
Contributor

isSerge commented Oct 4, 2022

As mentioned on the Dev Sync, frontend dependencies with vulnerabilities (got and git-clone) are devDependencies, which are not included in the production bundle. I also notified Quasar devs about these vulnerabilities and they promised to fix/update those

@ozgunozerk
Copy link
Contributor

The remaining unticked dependencies above, are not security issues, but rather warnings about unmaintained dependencies. Thus, they are not blockers for the audit. It is sufficient to have an issue for them to keep track.

These are indirect dependencies, and there are opened issues for replacing these unmaintained ones with alternatives. When the parent dependencies of these indirect ones, replace these unmaintained ones, we can upgrade our dependencies as well, and these minor warnings will be resolved then.

Again, since these are NOT security issues, it's not mandatory but a good to have to replace them when the appropriate time comes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

3 participants