Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hot reload schema in the query service on schema change #799

Closed
zhex opened this issue Feb 11, 2022 · 2 comments · Fixed by #1321 or #1401
Closed

hot reload schema in the query service on schema change #799

zhex opened this issue Feb 11, 2022 · 2 comments · Fixed by #1321 or #1401
Assignees
@jiqiang90 @bz888 @bighammerw
Labels
P1-asap
Projects
Development

Comments

@zhex
Copy link
Contributor

zhex commented Feb 11, 2022 •
edited

when an indexer updated/add a table, we have to restart the query service to get the latest schema generated from the db tables. this is not convenient and can be auto-updated.

graphile provides a watchSchema method may help. https://github.com/graphile/graphile-engine/blob/1619878d96/packages/graphile-build/src/SchemaBuilder.js#L526
@zhex zhex changed the title hot reload the query service on schema change hot reload schema in the query service on schema change Feb 11, 2022
@lamcc21 lamcc21 added the enhancement New feature or request label Mar 14, 2022
@bz888
Copy link
Contributor

bz888 commented Jun 22, 2022 •
edited

Useful links for this issue:

https://github.com/graphile/graphile-engine/tree/master/packages/postgraphile-core
https://github.com/apollographql/apollo-server/issues/1275
https://github.com/graphile/postgraphile/blob/818dad61a4d44d6a9aebdd8901ba58d104e1f562/src/postgraphile/postgraphile.ts#L137
https://www.apollographql.com/docs/federation/gateway/

@stwiname stwiname added this to To do in Development Jun 28, 2022
@jiqiang90 jiqiang90 added P1-asap and removed enhancement New feature or request labels Aug 17, 2022
@jiqiang90 jiqiang90 assigned jiqiang90 and unassigned lamcc21 Aug 17, 2022
@jamesbayly jamesbayly assigned lamcc21 and bz888 and unassigned lamcc21 Sep 22, 2022
@bz888 bz888 mentioned this issue Sep 27, 2022
Merged
3 tasks
@bz888 bz888 reopened this Oct 13, 2022
@jamesbayly
Copy link
Contributor

This is creating performance impacts on query service 1.6.0 - working on a work around

@bz888 bz888 mentioned this issue Nov 14, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiqiang90 jiqiang90

@bz888 bz888

@bighammerw bighammerw

Labels
P1-asap
Projects
No open projects
Development
To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hot schema reload subquery/subql
Hot schema trigger subquery/subql
6 participants
@zhex @lamcc21 @jiqiang90 @jamesbayly @bz888 @bighammerw