more consistent line splitting #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can I get in touch with a maintainer of this project ? |
|
Hi @LeGEC thanks for your contribution and sorry for the delay. |
luisdavim
reviewed
Jan 10, 2023
LeGEC
force-pushed
the
legec-cleanup-line-split
branch
from
fc2be8d
to
65c8557
Compare
change the scanner to split lines according to expected behavior, e.g: split lines on LF, CR or CRLF remove need for extra function to guess that after the facts Co-authored-by: Luis Davim <luis.davim@gmail.com>
|
@luisdavim : what would be a convenient way to PM you ? |
checked, it does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the scanner to split lines according to expected behavior, e.g: split lines on LF, CR or CRLF
remove need for extra function to guess that after the facts