Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marshal #17

Merged
merged 4 commits into from May 30, 2022
Merged

Marshal #17

merged 4 commits into from May 30, 2022

Conversation

luisdavim
Copy link
Collaborator

@luisdavim luisdavim commented May 22, 2022

Adding convenience methods for marshalling unmarshalling and writing envs to a file.
I've also added some performance tweaks, you can review each commit separately.

@luisdavim luisdavim force-pushed the marshal branch 2 times, most recently from 31e5477 to 21755a5 Compare May 22, 2022 22:35
@luisdavim
Copy link
Collaborator Author

@subosito sorry for the direct ping, I've been migrating some of the projects I help maintain from godotenv to gotenv and having these changes merged in and tagged would allow me to do it in a few more...

@subosito
Copy link
Owner

No problem @luisdavim! I have added you as a collaborator for this project, and let's move this forward.

@luisdavim
Copy link
Collaborator Author

luisdavim commented May 30, 2022

Awesome, thanks 😊 @subosito

BTW, even as a contributor, I don't think I can or should merge my own PRs.

@subosito
Copy link
Owner

Oops, sorry @luisdavim, I forgot to merge this PR after adding you as a collaborator 😝

@subosito subosito merged commit f7680c0 into subosito:master May 30, 2022
@luisdavim
Copy link
Collaborator Author

luisdavim commented May 30, 2022

@subosito I'm not sure I'm added as a collaborator, GH still tags me as just a contributor and I don't have access to close issues, merge PRs or push tags...

Maybe I need to log out and back in?

@luisdavim luisdavim deleted the marshal branch May 30, 2022 22:48
@subosito
Copy link
Owner

@luisdavim I think you should have gotten an invitation email from GitHub, and you need to click the confirmation link.

Just let me know if you have not gotten one, and I will resend the invitation.

@luisdavim
Copy link
Collaborator Author

Ah, got it, for some reason it went to my other email address. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants