Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline values #16

Merged
merged 5 commits into from May 22, 2022
Merged

Multiline values #16

merged 5 commits into from May 22, 2022

Conversation

luisdavim
Copy link
Collaborator

@luisdavim luisdavim commented May 21, 2022

Fixes #13 and #10

I've done some refactoring that should help improve performance a little bit, reviewing each commit individually might be easier.

@subosito
Copy link
Owner

Thanks, @luisdavim, this is huge! Could you please resolve the conflicts? So we can move forward.

@luisdavim
Copy link
Collaborator Author

Done, I've rebased my branch, thanks for looking into this so quickly 👍

@subosito subosito merged commit 408d487 into subosito:master May 22, 2022
@subosito
Copy link
Owner

Awesome!, thanks, @luisdavim 🎉

@luisdavim luisdavim deleted the multiline_values branch May 22, 2022 11:37
@luisdavim
Copy link
Collaborator Author

Thanks for merging this, would you mind creating a new tag?
You can also close #10 this inclues a new test confirming it's resolved.

@subosito
Copy link
Owner

Sure, @luisdavim, I have just released v1.3.0 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiline ENV variable?
2 participants