Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fvm config files as source for flutter-version-file #296

Open
ueman opened this issue Apr 2, 2024 · 4 comments
Open

Allow fvm config files as source for flutter-version-file #296

ueman opened this issue Apr 2, 2024 · 4 comments

Comments

@ueman
Copy link

ueman commented Apr 2, 2024

It would be nice if you could use fvm version files as source for the flutter-version-file parameter.

@kuhnroyal
Copy link
Contributor

I created #101 3 years ago, maybe this should be reconsiderd now that fvm is used widely.

@bartekpacia
Copy link
Collaborator

bartekpacia commented Apr 2, 2024

Hi @ueman and @kuhnroyal 👋🏻

I think it's a great idea! I just would like to make sure we do it right. I am myself not a heavy user of fvm – I only do fvm install x.y.z and then fvm global x.y.z. I know there's both fvm_config.json and sth like .fvvmrc since 3.0. Not sure what's the distinction/use cases and differences.

Feel free to make a PR that takes the above into account and updates the README accordingly.

@kuhnroyal
Copy link
Contributor

The 2 config files are basically the same. In FVM 3 the config file has just been separated from the .fvm SDK link.
A problem that comes to mind is the extra flavor config in FVM which will be hard to pass as an argument.

@dkbast
Copy link

dkbast commented Apr 15, 2024

When adding support for fvm it would be great if there would also be an fvm symlink so that we can use fvm flutter commands in our actions (e.g. using a steps from a Makefile)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants