Add Faker::File.dir #1361
Merged
Add Faker::File.dir #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
reviewed
Sep 26, 2018
vbrazo
approved these changes
Nov 12, 2018
Add Faker::File.dir for generating directory paths. Fix an imprecise test on Faker::File.file_name and update it to use the new Faker::File.dir method.
sanikkenway
referenced
this pull request
in sanikkenway/faker
Jun 24, 2019
Add Faker::File.dir (stympy#1361)
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* Add file dir Add Faker::File.dir for generating directory paths. Fix an imprecise test on Faker::File.file_name and update it to use the new Faker::File.dir method. * Update file.md
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add file dir Add Faker::File.dir for generating directory paths. Fix an imprecise test on Faker::File.file_name and update it to use the new Faker::File.dir method. * Update file.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Faker::File.dir for generating directory paths.
I'd like to take this further, but I think the ideal naming would break backwards compatibility. Anyways, here's what I have in mind:
Faker:File.dir— as implemented in this PRFaker:File.file_name— returns just the name part of the path (breaking change since the existing.file_namealso returns a path segment)Faker:File.path— returns a.dirwith a.file_name(basically like the current.file_name)Let me know any thoughts on this and how we might be able to move forward.