Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 558 Verb ing_forms from Verb base #1643

Merged
merged 1 commit into from Jul 3, 2019

Conversation

lightyrs
Copy link
Contributor

@lightyrs lightyrs commented Jul 3, 2019

Issue#

No-Story

Description:

This PR adds 558 Verbs from base to ing_form of the en locale. When this PR is merged, the base selection of the Faker::Verb en locale will have near-parity with the ing_form selection. It also removes an errant trailing-space from past in the en locale.

Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a big two line change :P

@vbrazo vbrazo merged commit 7e74df3 into faker-ruby:master Jul 3, 2019
sanikkenway added a commit to sanikkenway/faker that referenced this pull request Jul 8, 2019
Add 558 Verb ing_forms from Verb base (faker-ruby#1643)
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants