Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching from css to @adobe/css-tools #2709

Merged
merged 1 commit into from Aug 13, 2022
Merged

Switching from css to @adobe/css-tools #2709

merged 1 commit into from Aug 13, 2022

Conversation

holblin
Copy link
Contributor

@holblin holblin commented Aug 5, 2022

What:

Switching package css for @adobe/css-tools , fix #2665 closes #2707

Why:

css package is not maintained anymore and contain deprecated dependency

How:

Checklist:

  • Documentation
  • Unit Tests
  • Code complete
  • Changelog

@holblin holblin mentioned this pull request Aug 5, 2022
4 tasks
package-lock.json Outdated Show resolved Hide resolved
@holblin
Copy link
Contributor Author

holblin commented Aug 8, 2022

@iChenLei I regenerate the package-lock.json ;-)

@holblin holblin requested a review from iChenLei August 8, 2022 15:41
Copy link
Member

@iChenLei iChenLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@iChenLei iChenLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holblin
Copy link
Contributor Author

holblin commented Aug 12, 2022

I'm curious, what are the next steps before a release/merge?

@iChenLei
Copy link
Member

@holblin Hi, I only have time to work on open source projects on weekends. So I will check this PR again tomorrow. Maybe I will add more unit tests if needed. and then release 0.59.0. Anyway, thanks for your contribution again.

@iChenLei iChenLei merged commit 043d404 into stylus:dev Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning source-map-resolve
2 participants