Fix for Node v14 'Accessing non-existent property' errors

[3bl3gamer]

Fix for issue #2534

Why it happens

lib/nodes/index.js performs new exports.Boolean(true) which reads nodes.lineno. Since lineno is missing in lib/nodes, node.js outputs warnings. Same is for properties column and filename.

How to reproduce

With node v14:

npm install stylus
node
> require('stylus')

It will output

(node:117248) Warning: Accessing non-existent property 'lineno' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:117248) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:117248) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency
(node:117248) Warning: Accessing non-existent property 'lineno' of module exports inside circular dependency
(node:117248) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:117248) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency

1. Make sure you have tests for your modifications.

Are tests needed for this fix? If so what should they check?

[tcrowe]

I tested the patch it and it worked. I was getting the warning messages from using stylus and stylus-loader which are included in some webpack projects. Thank you @3bl3gamer

[tacomilkshake]

All confirmed this solves the issue for me.

[pztrick]

Patch works for me, thanks!

[queengooborg]

Another confirmation that the patch works -- can't wait for it to be merged so I can get rid of those pesky little warnings!

[peteringram0]

tested this patch on node v14.4.0 and this fixes the issue. Any update on when this will be merged?

[slightlyfaulty]

@xdan @dtvn PLEASE merge and release this patch so I don't have to do horrible things like this 😫

https://github.com/slightlyfaulty/stylus-native-loader#stylus-warnings-since-node-v14

[simonhaenisch]

please 😄

[AlynxZhou]

@xdan Please also update nib's dependency, it still uses old stylus. Thanks.