Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document this as official extension in README #31

Closed
BPScott opened this issue Dec 29, 2019 · 13 comments
Closed

Document this as official extension in README #31

BPScott opened this issue Dec 29, 2019 · 13 comments
Labels
type: documentation an improvement to the documentation
Milestone

Comments

@BPScott
Copy link
Contributor

BPScott commented Dec 29, 2019

This repo was originally published at https://marketplace.visualstudio.com/items?itemName=thibaudcolas.stylelint, but has since moved to https://marketplace.visualstudio.com/items?itemName=stylelint.vscode-stylelint.

What's going to happen to the extension published in the thibaudcolas namespace? Shall it be deleted? Deletion is be a bit of short-term pain - people wondering where their extension went - for long term consolidation around stylelint.vscode-stylelint.

@ntwb
Copy link
Member

ntwb commented Dec 29, 2019

It was originally published at https://marketplace.visualstudio.com/items?itemName=shinnn.stylelint and removed by the author (including the repo), the stylelint community has since adopted the extension, @thibaudcolas made that first version above available so that the extension continued to exist, and that repo has now moved to the @stylelint org.

So, yeah, not ideal, now that stylelint has moved the @thibaudcolas repo here I doubt we can update that extension to add a notice saying "Please use stylelint.vscode-stylelint` instead, we may have to just wait until the install count can indicate that it has become the canonical extension version...

@BPScott
Copy link
Contributor Author

BPScott commented Dec 29, 2019

What could be done is make thibaudcolas.stylelint be an empty extension that acts as a extension pack that installs stylelint.vscode-stylelint.

But if feels like that just puts off the pain - at some point it'd be nice to try and reduce the number of stylelint plugins to reduce the change of people getting confused.

@ntwb
Copy link
Member

ntwb commented Dec 29, 2019

Agreed, it would be great to have some of these extensions deprecated:

Pinging the following users regarding their extensions:

Now that the @stylelint org community has taken over the previous extension by @shinnn and now is up to date with the latest stylelint v12, supports autofix, and soon will no longer include the stylelint dependency (will use project installed version) would you consider deprecating your extensions in favor of this extension?

I'd be happy to also add all of you as contributors here on @stylelint

Release Notes: https://github.com/stylelint/vscode-stylelint/releases

@pqml
Copy link

pqml commented Dec 29, 2019

Oh this is good news!
I will deprecate my extension ASAP.

@BPScott
Copy link
Contributor Author

BPScott commented Dec 29, 2019

Seems we had similar ideas - I poked @hex-ci earlier :) hex-ci/vscode-stylelint-plus#18

@pqml
Copy link

pqml commented Jan 24, 2020

Sorry for the delay, I've just removed my extension and archived my github repo.

@thibaudcolas
Copy link
Member

thibaudcolas commented Feb 4, 2020

Sorry for the delay, I’ve also removed the extension I had temporarily published. It’s a bit unfortunate that vsce unpublish is all or nothing, there was no way to add any kind of deprecation message that I could see. The repository for the extension was the same as this one (we moved it here), so GitHub already redirects here.

The official extension already has the most downloads of all extensions, and it has a different logo so I think that will help it stand out.

If anything I’d suggest more people add a review to the extension over at https://marketplace.visualstudio.com/items?itemName=stylelint.vscode-stylelint&ssr=false#review-details.

@seangwright
Copy link

I followed the shinnn extension, which I had been using, to the @thibaudcolas one. Then I saw the "missing from marketplace" warning in VS Code and did a search and found this one.

I knew I was on the right track when I saw this issue. Maybe you can keep it pinned to help confirm to others that this is the extension they've been looking for (reverse jedi mind trick)?

@ntwb ntwb pinned this issue Feb 5, 2020
@ntwb ntwb changed the title Clarification of extension namespace New Offical Stylelint VSCode Extension: Clarification of extension namespace Feb 5, 2020
@zfwf
Copy link

zfwf commented Feb 14, 2020

Add one more to the list not mentioned above: stuartzhang.stylelint-stzhang

Hi @stuartZhang , you might want to consider contributing to this extension instead.

@jeddy3 jeddy3 added type: documentation an improvement to the documentation status: ready to implement is ready to be worked on by someone labels Mar 12, 2020
@jeddy3 jeddy3 changed the title New Offical Stylelint VSCode Extension: Clarification of extension namespace Document this as official extension in README Mar 12, 2020
@jeddy3
Copy link
Member

jeddy3 commented Mar 12, 2020

I knew I was on the right track when I saw this issue. Maybe you can keep it pinned to help confirm to others that this is the extension they've been looking for (reverse jedi mind trick)?

I think we can close this issue with some clear signposting in the README. We should clearly state somewhere prominent that this is the officially supported extension. Perhaps further down the page, we explain the historical fragmentation.

@adalinesimonian
Copy link
Member

I think we can close this issue with some clear signposting in the README. We should clearly state somewhere prominent that this is the officially supported extension. Perhaps further down the page, we explain the historical fragmentation.

In #232, I've updated the tagline at the top of the readme to say that this is the official extension. However, I haven't added any writing about the fragmentation. Given that it's been several years, is that still necessary? I'm not that familiar with the extension's history beyond what's discussed in this issue.

@jeddy3
Copy link
Member

jeddy3 commented Sep 25, 2021

The changes in #232 look good to me.

However, I haven't added any writing about the fragmentation. Given that it's been several years, is that still necessary?

I don't think it's something we can control and we're fine to close this issue now that #232 is merged.

This extension comes out top in searches for stylelint and has the most number of downloads.


Inncidently, you've done amazing work in #224 and #228. Thank you so much!

@adalinesimonian
Copy link
Member

However, I haven't added any writing about the fragmentation. Given that it's been several years, is that still necessary?

I don't think it's something we can control and we're fine to close this issue now that #232 is merged.

Great, going to close this. 🎉

Inncidently, you've done amazing work in #224 and #228. Thank you so much!

Thanks! There's more where that came from. 😉

@adalinesimonian adalinesimonian added this to the v0.87.0 milestone Sep 27, 2021
@adalinesimonian adalinesimonian added Fixed and removed status: ready to implement is ready to be worked on by someone labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation an improvement to the documentation
Projects
None yet
Development

No branches or pull requests

8 participants