Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylelint.validate in README doesn’t match with that in v1.0.0 Breaking change #268

Closed
1zumii opened this issue Oct 22, 2021 · 8 comments · Fixed by #270
Closed

stylelint.validate in README doesn’t match with that in v1.0.0 Breaking change #268

1zumii opened this issue Oct 22, 2021 · 8 comments · Fixed by #270
Assignees
Labels
good first issue is good for newcomers type: bug a problem with a feature or rule type: documentation an improvement to the documentation
Projects
Milestone

Comments

@1zumii
Copy link

1zumii commented Oct 22, 2021

README/Extension Settings

stylelint.validate

Type: string[]
Default: ["css","postcss"]
An array of language identifiers specifying which files to validate.

v1.0.0 changelog/Breaking changes

Validation and completion now only works for documents with language identifiers css, less, and postcss by default.

less is not set by default

@adalinesimonian adalinesimonian added good first issue is good for newcomers type: documentation an improvement to the documentation labels Oct 22, 2021
@adalinesimonian adalinesimonian added this to the On Deck milestone Oct 22, 2021
@adalinesimonian
Copy link
Member

Good catch! Updated the readme in 4464251.

@adalinesimonian adalinesimonian self-assigned this Oct 22, 2021
@1zumii
Copy link
Author

1zumii commented Oct 22, 2021

but my vscode can’t lint less file in v1.0.0, until i set stylelint.validate to [css, less, postcss]. so i think less is not default language

@adalinesimonian
Copy link
Member

adalinesimonian commented Oct 22, 2021

Looks like there's a mistake in the extension: all three languages are correctly specified in the server, but Less is missing from the extension manifest. I'll push up a patch update in a moment. Thank you again!

@adalinesimonian
Copy link
Member

@izumiiAoba I just pushed up v1.0.1, which should fix this problem. If it doesn't, let me know and I'll be happy to help!

@1zumii
Copy link
Author

1zumii commented Oct 24, 2021

it work nice, thanks a lot 😎

@jeddy3
Copy link
Member

jeddy3 commented Oct 25, 2021

@adalinesimonian Stylelint doesn't support Less out-of-the-box (a custom syntax is needed). Only CSS (and PostCSS because it's CSS-compatible) are. So, I believe the validate defaults were correct and it was the changelog and introduction in the README that were wrong.

Sorry that I missed this the first time around.

@adalinesimonian
Copy link
Member

@jeddy3 Huh! I wonder where Less snuck in, then. When I originally threw Less into the defaults, I was certain I had seen something about the defaults needing to be CSS, Less, and PostCSS, which is why I kept Less in the server defaults when preparing for v1/14. However, I went back and pulled up #233 and I don't see any mention of Less, either now or in a past edit of a comment. So I'm honestly not sure where it came from.

So should we pull it out of defaults, push out another patch, regretfully inform our bug-reporting friend here that we goofed up?

@jeddy3
Copy link
Member

jeddy3 commented Oct 25, 2021

So should we pull it out of defaults, push out another patch, regretfully inform our bug-reporting friend here that we goofed up?

Yes, I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue is good for newcomers type: bug a problem with a feature or rule type: documentation an improvement to the documentation
Projects
Bugs
Closed
Development

Successfully merging a pull request may close this issue.

3 participants