Fix declaration-block-no-duplicate-properties autofix for !important
#6528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c0f91b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ybiquitous
requested changes
Dec 16, 2022
There was a problem hiding this comment.
@sidx1024 Thanks for creating the PR! Additionally, could you add test cases to testRule with other secondary options?
ignore: [ 'consecutive-duplicates-with-different-values' ]ignore: [ 'consecutive-duplicates-with-same-prefixless-values' ]ignoreProperties: [ 'color' ]
|
@ybiquitous Added the requested test cases. |
ybiquitous
requested changes
Dec 20, 2022
There was a problem hiding this comment.
@sidx1024 Thank you. Could you address one more suggestion, please?
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
ybiquitous
changed the title
declaration-block-no-duplicate-properties autofix for !important
sidx1024
deleted the
sid/handle-important-for-declaration-block-no-duplicate-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6523
No, that's it.