Add media-feature-range-notation #6497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7d3c192 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
nit add |
Co-authored-by: sidverma32 <sid.verma32@gmail.com>
ybiquitous
reviewed
Nov 30, 2022
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
ybiquitous
approved these changes
Nov 30, 2022
All good catches, thanks. I've added a changelog entry. |
ybiquitous
approved these changes
Nov 30, 2022
This was referenced Dec 1, 2022
This was referenced Jul 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6161
Part of cleaning up our pull requests as we prepare for v15.
As mentioned in #6430 (comment), this pull request doesn't include autofix. I'll open a new issue for that. CssTools dropped a new media query parser the other day that may make implementating autofix more viable.
Additionally, I believe the edge-case of:
Should be transformed by this rule into:
That could then be merged into:
By another rule, one that sets the notation of media features in a range context. For example,
media-feature-range-context-notation:"separate"|"combined". I'll create another issue to discuss this, though. I wanted to mention it here to give context to this pull request.There are lots of terms in media queries. I've tried to get them right in the rule logic and test descriptions. Casting a second pair of eyes over these would be great.