Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit-no-unknown false positives for *vi & *vb viewport units #6428

Merged
merged 2 commits into from Oct 30, 2022

Conversation

sidverma32
Copy link
Contributor

Which issue, if any, is this issue related to?

Closes #6427

Is there anything in the PR that needs further explanation?

added the *vi and *vb units.

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2022

🦋 Changeset detected

Latest commit: ec1d8d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@jeddy3 jeddy3 changed the title fix: Add support for missing units in unit-no-unknown Fix unit-no-unknown false positives for *vi & *vb viewport units Oct 30, 2022
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix unit-no-unknown false positives for *vi & *vb viewport units
3 participants