Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cacheStrategy option #6357

Merged
merged 21 commits into from Sep 28, 2022
Merged

Conversation

kaorun343
Copy link
Contributor

Which issue, if any, is this issue related to?

close #6170

Is there anything in the PR that needs further explanation?

e.g. "No, it's self-explanatory."

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022

🦋 Changeset detected

Latest commit: 4ad3cc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lib/cli.js Outdated Show resolved Hide resolved
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaorun343 Thanks for this.

I've suggested a description for the option.

lib/cli.js Outdated Show resolved Hide resolved
docs/user-guide/usage/cli.md Outdated Show resolved Hide resolved
docs/user-guide/usage/options.md Show resolved Hide resolved
docs/user-guide/usage/options.md Outdated Show resolved Hide resolved
lib/cli.js Outdated Show resolved Hide resolved
lib/cli.js Show resolved Hide resolved
lib/__tests__/standalone-cache.test.js Show resolved Hide resolved
lib/utils/FileCache.js Show resolved Hide resolved
lib/utils/FileCache.js Outdated Show resolved Hide resolved
lib/__tests__/standalone-cache.test.js Outdated Show resolved Hide resolved
kaorun343 and others added 10 commits September 26, 2022 03:56
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
kaorun343 and others added 6 commits September 26, 2022 04:00
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Add metadata test
Update content test
@kaorun343
Copy link
Contributor Author

@ybiquitous Thanks for the review! I really appreciated for your support.

@jeddy3 Please review this PR again.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggest] Umm..., fs.utimes() fails on Windows with Date.now(). Instead, how about passing new Date()?

lib/__tests__/standalone-cache.test.js Outdated Show resolved Hide resolved
lib/__tests__/standalone-cache.test.js Outdated Show resolved Hide resolved
kaorun343 and others added 3 commits September 27, 2022 01:03
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've left a suggestion about the test, but the code looks almost good.

lib/__tests__/standalone-cache.test.js Show resolved Hide resolved
@jeddy3 jeddy3 mentioned this pull request Sep 27, 2022
6 tasks
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing several reviews and merging the main branch. LGTM 👍🏼

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaorun343 Thank you for adding this option. LGTM.

@ybiquitous Thank you for another comprehensive and excellent reviewing.

@jeddy3 jeddy3 merged commit d3ab981 into stylelint:main Sep 28, 2022
@kaorun343 kaorun343 deleted the feature/cache-strategy branch September 28, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add cacheStrategy option
3 participants